issues
search
code-423n4
/
2021-09-defiprotocol-findings
1
stars
0
forks
source link
issues
Newest
Newest
Most commented
Recently updated
Oldest
Least commented
Least recently updated
Gas: Can save an sload in `changePublisher`
#227
code423n4
opened
2 years ago
1
Gas: Improve `validateWeights` uniqueness check
#226
code423n4
closed
2 years ago
2
Gas: Factory parameter can be removed from Auction
#225
code423n4
opened
2 years ago
1
`newIbRatio` update math depends on how often it's called
#224
code423n4
opened
2 years ago
1
Re-entrancy in `settleAuction` allow stealing all funds
#223
code423n4
opened
2 years ago
2
Setting wrong publisher cannot be undone
#222
code423n4
opened
2 years ago
1
ERC20 return values not checked
#221
code423n4
closed
2 years ago
2
No ERC20 safe* versions called
#220
code423n4
closed
2 years ago
1
Re-entrancy in `Factory.createBasket`
#219
code423n4
opened
2 years ago
1
Wrong constant for `ONE_DAY`
#218
code423n4
opened
2 years ago
1
Style issues
#217
code423n4
opened
2 years ago
1
Eliminate hasBonded
#216
code423n4
opened
2 years ago
1
newIbRatio is not really useful
#215
code423n4
opened
2 years ago
1
Mint fees can be simplified
#214
code423n4
opened
2 years ago
1
Optimize validateWeights
#213
code423n4
closed
2 years ago
2
Functions that can be external not public
#212
code423n4
closed
2 years ago
2
Dead code
#211
code423n4
opened
2 years ago
1
Double division by BASE
#210
code423n4
opened
2 years ago
1
Cache the results of external calls
#209
code423n4
closed
2 years ago
2
Accessing the length of the array in every iteration is more gas expensive
#208
code423n4
closed
2 years ago
2
Re-entrancy guard
#207
code423n4
closed
2 years ago
2
Check the actual amounts transferred
#206
code423n4
opened
2 years ago
2
emit NewIBRatio in function initialize
#205
code423n4
opened
2 years ago
1
Duplicating variables across contracts
#204
code423n4
closed
2 years ago
2
Hardcoding numbers is error-prone
#203
code423n4
opened
2 years ago
1
Inconvenient to find bounty ids
#202
code423n4
opened
2 years ago
1
withdrawBounty the same bounty multiple times
#201
code423n4
closed
2 years ago
3
licenseFee state variable not checked for maximum value (Basket.sol)
#200
code423n4
opened
2 years ago
1
change visibility from to external for several functions
#199
code423n4
closed
2 years ago
1
redundant code (unused variables)
#198
code423n4
opened
2 years ago
1
multiply before divide
#197
code423n4
closed
2 years ago
1
Use safeTransfer instead of transfer
#196
code423n4
opened
2 years ago
1
block timestamp manipulation can cause fees change
#195
code423n4
opened
2 years ago
1
Re-entrancy in burn()
#194
code423n4
closed
2 years ago
2
Lack of Event Logging and Input Validation
#193
code423n4
opened
2 years ago
1
`onlyOwner` Role Can Unintentionally Influence `settleAuction()`
#192
code423n4
opened
2 years ago
2
Max approvals are risky if contract is malicious/compromised
#191
code423n4
opened
2 years ago
1
Recognize the risk of using approve
#190
code423n4
opened
2 years ago
1
Resetting partial struct fields is risky
#189
code423n4
opened
2 years ago
1
2-step change of publisher address and licenseFee does not generate warning event
#188
code423n4
opened
2 years ago
2
2-step change of publisher address is not robust to errors
#187
code423n4
closed
2 years ago
1
Incorrectly used new publisher and new licenseFee cannot be changed
#186
code423n4
opened
2 years ago
1
Publisher role cannot be renounced
#185
code423n4
opened
2 years ago
1
Potential reentrancies possible
#184
code423n4
closed
2 years ago
2
Missing error message strings with require()s
#183
code423n4
closed
2 years ago
2
Basket can be initialized multiple times to completely take over the Basket contract
#182
code423n4
closed
2 years ago
3
Timelock duration assumed 15s block times
#181
code423n4
closed
2 years ago
1
Using the latest compiler version may be susceptible to undiscovered bugs
#180
code423n4
opened
2 years ago
2
Separate proposeBasketLicense() and createBasket() functions may lead to unexpected behavior
#179
code423n4
closed
2 years ago
2
Missing emission of basket ID and token composition
#178
code423n4
opened
2 years ago
2
Previous
Next