issues
search
code-423n4
/
2021-11-streaming-findings
0
stars
0
forks
source link
issues
Newest
Newest
Most commented
Recently updated
Oldest
Least commented
Least recently updated
Gas wastage :: feePercent value checked twice
#222
code423n4
closed
2 years ago
1
Loss of precision causing incorrect flashloan & creator fee calculation
#221
code423n4
opened
2 years ago
3
Gas: Flashloan only needs to check pre/post balance for `token`
#220
code423n4
closed
2 years ago
1
Gas: Batch transfer in `claimFees`
#219
code423n4
closed
2 years ago
1
Gas: Unnecessary scaling
#218
code423n4
closed
2 years ago
1
Gas: Check `_feePercent` instead
#217
code423n4
opened
2 years ago
0
Gas: `unstreamed` not needed
#216
code423n4
opened
2 years ago
0
Tokens can be stolen when `depositToken == rewardToken`
#215
code423n4
opened
2 years ago
1
Reward token not correctly recovered
#214
code423n4
opened
2 years ago
1
Inaccurate comment in `recoverTokens`
#213
code423n4
opened
2 years ago
0
Recover tokens function will become unusable with reward tokens if they are withdrawn first.
#212
code423n4
closed
2 years ago
1
Locke.sol:Stream - `recoverTokens` can bork `depositToken` balance
#211
code423n4
closed
2 years ago
1
Locke.sol:Stream - possible DOS on `arbitraryCall`
#210
code423n4
closed
2 years ago
1
Locke.sol:Stream - `arbitraryCall` can be used to drain incentive tokens
#209
code423n4
closed
2 years ago
1
Broken logic if rewardToken == depositToken
#208
code423n4
closed
2 years ago
1
Locke.t.sol - duplicate test
#207
code423n4
closed
2 years ago
1
`recoverTokens` did not consider depositTokenFlashloanFeeAmount
#206
code423n4
closed
2 years ago
1
Gas optimization: Use else if for mutually exclusive conditions
#205
code423n4
closed
2 years ago
1
Token owner cannot claim rewardToken if they are not the original depositor
#204
code423n4
opened
2 years ago
2
Gas Optimization: Empty else block in `withdraw`
#203
code423n4
closed
2 years ago
1
Gas Optimization: Empty else block
#202
code423n4
closed
2 years ago
1
Incentives paid to creator instead of depositor
#201
code423n4
opened
2 years ago
2
`arbitraryCall` allow inherited governance to steal incentives
#200
code423n4
closed
2 years ago
3
Possible incentive theft through the arbitraryCall() function
#199
code423n4
opened
2 years ago
1
No minimum size for flashloan leads to small feeless flashloans
#198
code423n4
closed
2 years ago
1
Gas Optimization: Unnecessary flashloan checks
#197
code423n4
closed
2 years ago
1
Unneeded checks in the flashloan function
#196
code423n4
closed
2 years ago
1
Extra fees paid for flash loans are unassigned
#195
code423n4
closed
2 years ago
0
For uint `> 0` can be replaced with ` != 0` for gas optimization
#194
code423n4
closed
2 years ago
1
Token allowances vulnerable to front-running
#193
code423n4
closed
2 years ago
2
This protocol doesn't support all fee on transfer tokens
#192
code423n4
opened
2 years ago
1
Don't cache `b1` and `temp` in toString
#191
code423n4
closed
2 years ago
1
In claimReward, reward can be cached more efficiently.
#190
code423n4
opened
2 years ago
0
Not needed lastApplicableTime call in claimReward
#189
code423n4
opened
2 years ago
0
Directly calculate fee in flash loan
#188
code423n4
opened
2 years ago
0
When exit is called, updateStream is called twice
#187
code423n4
opened
2 years ago
0
fundStream can be implemented more efficiently
#186
code423n4
opened
2 years ago
0
No need to check fee inside factories constructor
#185
code423n4
opened
2 years ago
0
depositToken has to be not equal rewardToken
#184
code423n4
closed
2 years ago
1
Gas Optimization: Use minimal proxy
#183
code423n4
opened
2 years ago
0
Deposit token flash loan fees can be stolen by streamCreator
#182
code423n4
closed
2 years ago
1
Gas Optimization: Move common logic out of if block
#181
code423n4
opened
2 years ago
0
If the stream is a sale recover tokens function won't work.
#180
code423n4
closed
2 years ago
1
Eliminate amt in fundStream
#179
code423n4
opened
2 years ago
0
empty else
#178
code423n4
closed
2 years ago
1
exit and withdraw both performs updateStream
#177
code423n4
closed
2 years ago
1
Unchecked math operations
#176
code423n4
closed
2 years ago
1
eliminate multiplication in feeAmt calculation
#175
code423n4
closed
2 years ago
1
`arbitraryCall` enables `streamCreator` to remove incentive tokens before `endStream`
#174
code423n4
closed
2 years ago
2
Assigned operations to constant variables
#173
code423n4
closed
2 years ago
1
Previous
Next