issues
search
code-423n4
/
2021-04-vader-findings
1
stars
0
forks
source link
issues
Newest
Newest
Most commented
Recently updated
Oldest
Least commented
Least recently updated
Hardcoded middle price index is not always accurate
#270
code423n4
closed
3 years ago
1
_recordBurn does not handle 0 _eth appropriately
#269
code423n4
opened
3 years ago
0
You can vote for proposal already completed
#268
code423n4
closed
3 years ago
5
mapping _isMember is never set
#267
code423n4
closed
3 years ago
2
deploySynth does not prevent token to be VADER or USDV
#266
code423n4
closed
3 years ago
3
The decimals shoul be uint8
#265
code423n4
closed
3 years ago
2
Anyone can modify important state variables
#264
code423n4
closed
3 years ago
3
Function can be simplified
#263
code423n4
opened
3 years ago
0
Token can be burn through transfer
#262
code423n4
opened
3 years ago
0
Code is different from comment
#261
code423n4
closed
3 years ago
1
Code different from comment
#260
code423n4
closed
3 years ago
1
The flashProof check can be bypassed at the start
#259
code423n4
closed
3 years ago
1
Use Keccak256 over Sha256 for string comparation
#258
code423n4
opened
3 years ago
0
Missing events for important changes in protocol
#257
code423n4
closed
3 years ago
1
Not needed check for uint > 0
#256
code423n4
opened
3 years ago
2
Divide before multiply
#255
code423n4
opened
3 years ago
1
Function can be simplified
#254
code423n4
closed
3 years ago
2
Gas improvement
#253
code423n4
opened
3 years ago
0
Store using Struct over multiple mappings
#252
code423n4
opened
3 years ago
0
Difference from whitepaper
#251
code423n4
opened
3 years ago
0
Events not emitted
#250
code423n4
opened
3 years ago
2
Allowance not checked when calling transferFrom
#249
code423n4
closed
3 years ago
3
Variables can be declared constant
#248
code423n4
closed
3 years ago
2
Unused state variables
#247
code423n4
closed
3 years ago
2
Public function that could be declared external
#246
code423n4
closed
3 years ago
2
Missing zero address validation in the init methods
#245
code423n4
closed
3 years ago
1
Incorrect liquidity unit calculation in Utils.sol
#244
code423n4
closed
3 years ago
2
Incorrect AsymmetricShare calculation in Utils.sol
#243
code423n4
closed
3 years ago
2
Missing zero-address check for recipient address in critical _transfer() function of Synth.sol
#242
code423n4
closed
3 years ago
2
Missing event for critical changeUTILS() function in Vader.sol
#241
code423n4
closed
3 years ago
4
Missing zero-address check for recipient address in critical _transfer() function of VADER.sol
#240
code423n4
closed
3 years ago
2
Missing zero-address check for recipient address in critical _transfer() function of USDV.sol
#239
code423n4
closed
3 years ago
2
Tokens can get locked and funds lost when minting is disabled in Vader.sol and USDV.sol
#238
code423n4
opened
3 years ago
2
Missing event for critical flipMinting() function in Vader.sol
#237
code423n4
closed
3 years ago
2
Add anchor map
#236
code423n4
opened
3 years ago
1
State variables should be constant
#235
code423n4
closed
3 years ago
2
`DAO.finaliseProposal` if branch seems unnecessary
#234
code423n4
closed
3 years ago
2
`DAO.mapPID_finalised` is never read in the contract, only written
#233
code423n4
opened
3 years ago
1
cache `proposalCount` instead of accessing it three times in `newGrantProposal`/`newAddressProposal`
#232
code423n4
opened
3 years ago
0
ERC20 return values not checked
#231
code423n4
opened
3 years ago
0
`Protection` event not used
#230
code423n4
opened
3 years ago
0
Completed proposals can be voted on and executed again
#229
code423n4
opened
3 years ago
1
Canceled proposals can still be executed
#228
code423n4
opened
3 years ago
1
Proposals can be cancelled
#227
code423n4
opened
3 years ago
3
`init` functions can be frontrun
#226
code423n4
closed
3 years ago
1
Missing Approval event in Vether
#225
code423n4
closed
3 years ago
2
Vault Weight accounting is wrong for withdrawals
#224
code423n4
opened
3 years ago
3
Vault rewards last claim time not always initialized
#223
code423n4
opened
3 years ago
2
Vault rewards can be gamed
#222
code423n4
opened
3 years ago
2
Fee can be at most 1% and dead code
#221
code423n4
opened
3 years ago
0
Previous
Next