code-423n4 2021-08-notional-findings issues

code-423n4 / 2021-08-notional-findings

3 stars 0 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

Potential DOS in Contracts Inheriting `UUPSUpgradeable.sol`

#98 code423n4 opened 3 years ago
6
Non-existent `nERC1155Interface.supportsInterface.selector`

#97 code423n4 opened 3 years ago
2
`StorageLayoutV1` Gas Optimisations

#96 code423n4 opened 3 years ago
0
Missing SPDX Identifier

#95 code423n4 opened 3 years ago
2
No Transfer Ownership Pattern

#94 code423n4 opened 3 years ago
0
Lack of Zero Address Validation

#93 code423n4 opened 3 years ago
1
Missing validation on latestRoundData

#92 code423n4 opened 3 years ago
1
Replacing the assembly `extcodesize` checks for versions `>0.8.1`

#91 code423n4 opened 3 years ago
4
Used a fixed or pragma that spans only a single `0.x.*`

#90 code423n4 opened 3 years ago
0
Consider using assembly instead of the lengthy if statement in Router.sol

#89 code423n4 opened 3 years ago
2
Caching length in for loops

#88 code423n4 opened 3 years ago
0
Upgrade to at least 0.8.4

#87 code423n4 opened 3 years ago
2
Liquidator can be liquidatee

#86 code423n4 opened 3 years ago
2
Liquidity token value can be manipulated

#85 code423n4 opened 3 years ago
2
Use of `msg.value` in batch action

#84 code423n4 opened 3 years ago
2
ChainLink price data could be stale

#83 code423n4 opened 3 years ago
2
`DateTime.getMarketIndex` bounds should be tighter

#82 code423n4 opened 3 years ago
0
`DateTime.isValidMarketMaturity` bounds should be tighter

#81 code423n4 opened 3 years ago
0
`TokenHandler.safeTransferIn` does not work on non-standard compliant tokens like USDT

#80 code423n4 opened 3 years ago
0
`TokenHandler.safeTransferOut` does not work on non-standard compliant tokens like USDT

#79 code423n4 opened 3 years ago
0
`TokenHandler.transfer` wrong branch order

#78 code423n4 opened 3 years ago
0
`TokenHandler.setToken` ERC20 missing return value check

#77 code423n4 opened 3 years ago
0
NoteERC20.getPriorVotes includes current unclaimed incentives

#76 code423n4 opened 3 years ago
2
NoteERC20 _authorizeUpgrade not implemented

#75 code423n4 opened 3 years ago
2
NoteERC20 missing initial ownership event

#74 code423n4 opened 3 years ago
0
Governor average block time is not up-to-date

#73 code423n4 opened 3 years ago
0
nTokenERC20Proxy emits events even when not success

#72 code423n4 opened 3 years ago
0
Access restrictions on `NotionalV1ToNotionalV2.notionalCallback` can be bypassed

#71 code423n4 opened 3 years ago
0
Unclear decimals value in `cTokenAggregator`

#70 code423n4 opened 3 years ago
1
Access restrictions on `CompoundToNotionalV2.notionalCallback` can be bypassed

#69 code423n4 opened 3 years ago
0
`CompoundToNotionalV2.notionalCallback` ERC20 return values not checked

#68 code423n4 opened 3 years ago
0
`CompoundToNotionalV2.enableToken` ERC20 missing return value check

#67 code423n4 opened 3 years ago
0
Allowance checks not correctly implemented

#66 code423n4 opened 3 years ago
0
`nTokenAction` does not emit Approval events

#65 code423n4 opened 3 years ago
2
Router calls to `nTokenAction.nTokenTransferApprove` fail

#64 code423n4 opened 3 years ago
1
Open TODOs in `ERC1155Action`

#63 code423n4 opened 3 years ago
0
Untrusted externall call on `ERC1155Action.safeTransfer*`

#62 code423n4 opened 3 years ago
0
ERC1155Action returns `false` on `supportsInterface` with the real ERC1155 interface

#61 code423n4 opened 3 years ago
0
Privilige escalation in ERC1155

#60 code423n4 opened 3 years ago
2
`initialize` functions can be frontrun

#59 code423n4 opened 3 years ago
0
DAO proposals can be executed by anyone due to vulnerable TimelockController

#58 code423n4 opened 3 years ago
0
Missing parameter validation

#57 code423n4 opened 3 years ago
1
Total supply dependency on decimals

#56 code423n4 opened 3 years ago
0
Wrong order in Approval event

#55 code423n4 opened 3 years ago
0
Cache values that are accessed more than once

#54 code423n4 opened 3 years ago
1
uint is always >= 0

#53 code423n4 opened 3 years ago
1
Unused variables

#52 code423n4 opened 3 years ago
2
lack of zero address validation in constructor

#51 code423n4 opened 3 years ago
1
lack of require message

#50 code423n4 opened 3 years ago
2
transferOwnership should be two step process

#49 code423n4 opened 3 years ago
1