issues
search
code-423n4
/
2021-11-nested-findings
1
stars
1
forks
source link
issues
Newest
Newest
Most commented
Recently updated
Oldest
Least commented
Least recently updated
`_calculateFess` takes user argument as address but unused and can be marked pure
#233
code423n4
closed
2 years ago
2
Unused variable "tokens"
#232
code423n4
closed
2 years ago
3
Does not check uniqueness of ShareHolder
#231
code423n4
closed
2 years ago
1
change variable location to memory from storage in getAmountsDue (view function)
#230
code423n4
closed
2 years ago
2
nonReentrant modifier causing DOS for releaseTokens
#229
code423n4
closed
2 years ago
3
no
#228
code423n4
closed
2 years ago
1
NestedFactory inherits from OpenZeppelin Multicall, which multicall function allows reusage of msg.value within ETH depositing
#227
code423n4
closed
2 years ago
2
Passing multiple ETH deposits in orders array will use the same msg.value many times
#226
code423n4
opened
2 years ago
2
Save storage NestedRecords.records.reserve address variable to memory
#225
code423n4
closed
2 years ago
2
Validations of parameters
#224
code423n4
closed
2 years ago
2
NestedFactory._decreaseHoldingAmount needs explicit amount control for spending reserve
#223
code423n4
opened
2 years ago
2
fillQuote returned value
#222
code423n4
closed
2 years ago
1
Long Revert Strings
#221
code423n4
closed
2 years ago
1
NestedFactory.removeOperator code doesn't correspond to it's logic
#220
code423n4
opened
2 years ago
2
NestedFactory.FeeSplitter can be immediatly changed with current and future fees lost to a malicious Owner
#219
code423n4
closed
2 years ago
2
NestedReserve.updateFactory function can be used for stealing all contract funds (rug)
#218
code423n4
closed
2 years ago
2
Ensure on-chain that cache is synced
#217
code423n4
opened
2 years ago
2
msg.sender used in ZeroExOperator.sol
#216
code423n4
closed
2 years ago
1
setMaxAllowance
#215
code423n4
closed
2 years ago
1
Unchecked operations
#214
code423n4
closed
2 years ago
1
mintWithMetadata onlyFactory
#213
code423n4
opened
2 years ago
0
.length in a loop
#212
code423n4
closed
2 years ago
1
Accessing the same storage value multiple times
#211
code423n4
closed
2 years ago
1
OperatorResolver.areAddressesImported doesn't check lengths of argument arrays
#210
code423n4
opened
2 years ago
0
Shorter revert messages
#209
code423n4
closed
2 years ago
1
_burnNST
#208
code423n4
opened
2 years ago
0
index + 1 can be simplified
#207
code423n4
opened
2 years ago
0
INestedToken interface
#206
code423n4
opened
2 years ago
0
Division by 0 totalWeights
#205
code423n4
closed
2 years ago
1
NestedAsset.setFactory should be named addFactory
#204
code423n4
opened
2 years ago
0
Can't revoke factory in NestedRecrods
#203
code423n4
opened
2 years ago
0
safeTransfer of tokens
#202
code423n4
closed
2 years ago
1
NestedFactory._calculateFees should be pure to save on call costs
#201
code423n4
closed
2 years ago
2
Cant remove the first operator
#200
code423n4
closed
2 years ago
2
NestedFactory.addTokens and withdraw functions require NFT reserve check
#199
code423n4
opened
2 years ago
0
Check condition before calling NestedFactory._handleUnderSpending
#198
code423n4
opened
2 years ago
0
Function NestedFactory.destroy doesn't check amounts returned after executing user's market order to sell a portfolio
#197
code423n4
closed
2 years ago
2
Function NestedFactory._submitOutOrders doesn't check amounts returned from market executing of user's orders
#196
code423n4
closed
2 years ago
1
Unused local variables
#195
code423n4
opened
2 years ago
2
calculateFees Issues (NestedFactory.sol)
#194
code423n4
closed
2 years ago
1
Small refactor for functions to save some gas
#193
code423n4
opened
2 years ago
0
Event needs to be emitted in the Operator module
#192
code423n4
closed
2 years ago
2
Tokens can get stuck in _submitOutOrders
#191
code423n4
closed
2 years ago
2
`> 0 can be replaced with != 0 for gas optimisation`
#190
code423n4
closed
2 years ago
1
Gas Optimization on the Public Functions
#189
code423n4
closed
2 years ago
1
Restrict funds receivable to be only from wrapped native token
#188
code423n4
closed
2 years ago
2
nonReentrant modifier isn't necessary for releaseToken function
#187
code423n4
closed
2 years ago
2
Cache array length in for loops can save gas
#186
code423n4
closed
2 years ago
1
Unnecessary Use of _msgSender()
#185
code423n4
opened
2 years ago
1
Gas: Unnecessary `balanceOf` call
#184
code423n4
closed
2 years ago
1
Next