zlsecure3 review_star issues

zlsecure3 / review_star

0 stars 0 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

Chainlink's latestRoundData might return stale or incorrect results

#63 zlsecure3 opened 1 year ago
0
The logic of `assert` is wrong.

#62 zlsecure3 opened 1 year ago
3
Index out of bound.

#61 zlsecure3 opened 1 year ago
3
User can free from fee.

#60 zlsecure3 opened 1 year ago
3
There is no guarantee that domain shortest length is less than or equal to the longest length.

#59 zlsecure3 opened 1 year ago
3
a few typo in `Resovler.move` contract `set_reverse_default_resolver` function

#58 zlsecure3 opened 1 year ago
3
check is incomplete in `StarNameService.move` contract `check_prefix_length_isLegal` function

#57 zlsecure3 opened 1 year ago
3
resource_account variable is unused in `StarNameService.move` contract `initialize_name_services` function

#56 zlsecure3 opened 1 year ago
3
uri parameter is not used in `StarNameService.move` contract `create_name_script` function

#55 zlsecure3 opened 1 year ago
3
code can be refined in `StarNameService.move` contract `create_name_script_nft` function

#54 zlsecure3 opened 1 year ago
3
code can be refined in `StarNameService.move` contract `renew_name_script` function

#53 zlsecure3 opened 1 year ago
3
No need for ex_expire_time in `StarNameService` contract `renew_name_script` function

#52 zlsecure3 opened 1 year ago
3
`supplied` never updated.

#51 zlsecure3 opened 1 year ago
3
`Airdop::airdrop` can airdrop unlimitted amount that greater than the `maxmium_supple`.

#50 zlsecure3 opened 1 year ago
3
Gas Optimization in `StarNameService` contract `renew_name_script` function

#49 zlsecure3 opened 1 year ago
3
Gas Optimization in `StarNameService` contract `create_name_script` function

#48 zlsecure3 opened 1 year ago
3
Code Style in `Airdrop` contract `consume` function

#47 zlsecure3 opened 1 year ago
3
Logical risk in `Airdrop` contract `airdrop ` function

#46 zlsecure3 opened 1 year ago
4
unused function

#45 zlsecure3 opened 1 year ago
3
Struce data empty

#44 zlsecure3 opened 1 year ago
3
Data not updated in time

#43 zlsecure3 opened 1 year ago
3
Wrong airdrop address

#42 zlsecure3 opened 1 year ago
3
Wrong main_uri append

#41 zlsecure3 opened 1 year ago
3
Risk of registered domain being front-run

#40 zlsecure3 opened 1 year ago
3
Redundant initialize_token_store operation

#39 zlsecure3 opened 1 year ago
3
Expired SNS NFTs are not processed

#38 zlsecure3 opened 1 year ago
3
Design flaw of StarNameService NFT and NameServices resource

#37 zlsecure3 opened 1 year ago
3
Resource operation type usage error

#36 zlsecure3 opened 1 year ago
3
Airdrop's supplied check is flawed

#35 zlsecure3 opened 1 year ago
3
Lack of limiting the length of `prefix` in function `check_prefix_length_isLegal`.

#34 zlsecure3 opened 1 year ago
3
Did not check whether the account contained the related resources before calling `borrow_global_mut`.

#33 zlsecure3 opened 1 year ago
3
Did not check whether the table contained the related element before calling `table::borrow`.

#32 zlsecure3 opened 1 year ago
4
The relationship of two parameters has not been checked.

#31 zlsecure3 opened 1 year ago
3
The consumption of fee may be calculated as 0.

#30 zlsecure3 opened 1 year ago
3
Input parameter `to` has not been used by the function `airdrop_mint`.

#29 zlsecure3 opened 1 year ago
3
The logic of `assert` is wrong.

#28 zlsecure3 opened 1 year ago
3
Index out of bound.

#27 zlsecure3 opened 1 year ago
3
User can free from fee.

#26 zlsecure3 opened 1 year ago
3
There is no guarantee that domain shortest length is less than or equal to the longest length.

#25 zlsecure3 opened 1 year ago
3
a few typo in `Resovler.move` contract `set_reverse_default_resolver` function

#24 zlsecure3 opened 1 year ago
3
check is incomplete in `StarNameService.move` contract `check_prefix_length_isLegal` function

#23 zlsecure3 opened 1 year ago
3
resource_account variable is unused in `StarNameService.move` contract `initialize_name_services` function

#22 zlsecure3 opened 1 year ago
3
uri parameter is not used in `StarNameService.move` contract `create_name_script` function

#21 zlsecure3 opened 1 year ago
3
code can be refined in `StarNameService.move` contract `create_name_script_nft` function

#20 zlsecure3 opened 1 year ago
3
code can be refined in `StarNameService.move` contract `renew_name_script` function

#19 zlsecure3 opened 1 year ago
3
No need for ex_expire_time in `StarNameService` contract `renew_name_script` function

#18 zlsecure3 opened 1 year ago
3
`supplied` never updated.

#17 zlsecure3 opened 1 year ago
3
`Airdop::airdrop` can airdrop unlimitted amount that greater than the `maxmium_supple`.

#16 zlsecure3 opened 1 year ago
3
`Airdop::airdrop` can airdrop unlimitted amount that greater than the `maxmium_supple`.

#15 zlsecure3 opened 1 year ago
2
`Airdop::airdrop` can airdrop unlimitted amount that greater than the `maxmium_supple`.

#14 zlsecure3 opened 1 year ago
1