code-423n4 2021-10-ambire-findings issues

code-423n4 / 2021-10-ambire-findings

0 stars 0 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

create2 assembly

#67 code423n4 closed 3 years ago
3
Hex selector

#66 code423n4 opened 3 years ago
2
Only prepare tx when the fee is present

#65 code423n4 opened 3 years ago
6
Unchecked math operations

#64 code423n4 closed 3 years ago
4
Pack structs tightly

#63 code423n4 closed 3 years ago
2
Cache storage access

#62 code423n4 closed 3 years ago
2
Immutable variables

#61 code423n4 closed 3 years ago
2
block.timestamp cannot be 0

#60 code423n4 closed 3 years ago
2
Unused imports

#59 code423n4 closed 3 years ago
2
LibBytes uses itself

#58 code423n4 opened 3 years ago
2
Duplicate math operations

#57 code423n4 opened 3 years ago
2
ecrecover may return empty address

#56 code423n4 opened 3 years ago
3
block.chainid may change in case of a hardfork

#55 code423n4 opened 3 years ago
2
Hardcoded WETH

#54 code423n4 opened 3 years ago
3
lack of require message

#53 code423n4 opened 3 years ago
2
State variable that can be decalred as constant

#52 code423n4 closed 3 years ago
3
use of floating pragma

#51 code423n4 opened 3 years ago
2
lack of checking of address in array

#50 code423n4 closed 3 years ago
3
Incorrect checking of signature length

#49 code423n4 closed 3 years ago
2
No account existence check for low-level call

#48 code423n4 opened 3 years ago
2
unchecked return value from transfer()

#47 code423n4 closed 3 years ago
2
Adding unchecked directive can save gas

#46 code423n4 opened 3 years ago
2
Inconsistent code style of for loops

#45 code423n4 opened 3 years ago
2
Using SafeERC20 in recoverFunds()

#44 code423n4 closed 3 years ago
2
Call deposit() in the WETH contract

#43 code423n4 closed 3 years ago
2
Gas: `SignatureValidatorV2.recoverAddrImpl` should use `else if`

#42 code423n4 opened 3 years ago
2
Gas: `BytesLib` addition can be unchecked

#41 code423n4 opened 3 years ago
2
QuickAccManager Smart Contract signature verification can be exploited

#40 code423n4 opened 3 years ago
6
Signature replay attacks for different identities (nonce on wrong party)

#39 code423n4 opened 3 years ago
3
No check for signature malleability

#38 code423n4 opened 3 years ago
2
If zero address is added as privilege anyone can execute arbitrary transactions

#37 code423n4 opened 3 years ago
3
`Identity` fallback returns too many bytes

#36 code423n4 opened 3 years ago
3
No ERC20 safe* versions called & no return values checked

#35 code423n4 opened 3 years ago
3
`Zapper` withdrawals from Aave might not work as intended

#34 code423n4 closed 3 years ago
2
`Zapper` only works for whitelisted tokens

#33 code423n4 opened 3 years ago
2
`Zapper` should safeApprove(0) first

#32 code423n4 opened 3 years ago
2
`QuickAccManager.sol` Constants should be marked as `constant`

#31 code423n4 opened 3 years ago
2
Cache storage variables in the stack can save gas

#30 code423n4 opened 3 years ago
3
Unnecessary storage variables

#29 code423n4 opened 3 years ago
2
`Zapper.sol#tradeV3Single()` Remove unnecessary variable can make the code simpler and save gas

#28 code423n4 opened 3 years ago
2
`Zapper.sol#wrapETH()` Use `WETH.deposit` can save some gas

#27 code423n4 opened 3 years ago
2
Cache array length in for loops can save gas

#26 code423n4 opened 3 years ago
3
`QuickAccManager.sol#send()` Avoid unnecessary read from storage can save gas

#25 code423n4 opened 3 years ago
2
`QuickAccManager.sol` Potential replay attack

#24 code423n4 closed 3 years ago
3
`QuickAccManager.sol#send()` Potential replay attack

#23 code423n4 closed 3 years ago
2
Save Gas With The Unchecked Keyword

#22 code423n4 closed 3 years ago
2
Call to swapExactTokensForTokens in exchangeV2() will always fail without approvement

#21 code423n4 closed 3 years ago
2
Use safeTransfer/safeTransferFrom consistently instead of transfer/transferFrom

#20 code423n4 closed 3 years ago
2
Double check for "birthday" collision

#19 code423n4 closed 3 years ago
2
Use of safeApprove will always cause approveMaxMany to revert

#18 code423n4 closed 3 years ago
4