code-423n4 2021-12-defiprotocol-findings issues

code-423n4 / 2021-12-defiprotocol-findings

0 stars 0 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

Use of deprecated `safeApprove()` function

#177 code423n4 opened 2 years ago
2
Reentrancy vulnerability in `Basket` contract's `initialize()` method.

#176 code423n4 opened 2 years ago
1
Usage of deprecated safeApprove

#175 code423n4 closed 2 years ago
1
Dust can't be withdrawn

#174 code423n4 closed 2 years ago
2
Dust can't be withdrawn

#173 code423n4 closed 2 years ago
1
A `delegatecall` to `createBasket` compromises `Auction` and `Basket` references to `Factory` contract.

#172 code423n4 closed 2 years ago
2
Basket airdops can't be claimed

#171 code423n4 closed 2 years ago
2
Basket:handleFees(): fees are overcharged

#170 code423n4 opened 2 years ago
4
No access control on initialise() will lead to stolen funds

#169 code423n4 closed 2 years ago
2
Caching array length will save gas [Basket.sol]

#168 code423n4 closed 2 years ago
1
Auction:bondBurn(): cache bondAmount

#167 code423n4 opened 2 years ago
0
Auction:bondForRebalance() store calculation of bondAmount in local variable

#166 code423n4 opened 2 years ago
0
Check for tokenAmount > 0 is missing in pushUnderlying function [basket.sol]

#165 code423n4 opened 2 years ago
2
Auction:settleAuction() cache address(basket)

#164 code423n4 opened 2 years ago
0
Unnecessary uint zero initialization

#163 code423n4 closed 2 years ago
1
Function changePublisher, changeLicenseFee, and setNewMaxSupply can be refactored for efficiency and clarity

#162 code423n4 opened 2 years ago
0
Function handleFees #L148-L151 and updateIBRatio (Basket.sol) can be refactored for efficiency and clarity

#161 code423n4 opened 2 years ago
0
Unused Named Return

#160 code423n4 closed 2 years ago
1
Assignment Of Variable To Default in the constructor

#159 code423n4 closed 2 years ago
1
"> 0" is less efficient than "!= 0" for unsigned integers

#158 code423n4 closed 2 years ago
1
Open TODOs

#157 code423n4 opened 2 years ago
0
Comparison with literal boolean values

#156 code423n4 closed 2 years ago
1
divide-before-multiply

#155 code423n4 closed 2 years ago
1
Missing cap on LicenseFee

#154 code423n4 opened 2 years ago
2
Gas Optimization: Remove unnecessary init to default value

#153 code423n4 closed 2 years ago
1
Fee calculation is slightly off

#152 code423n4 opened 2 years ago
2
`safeApprove` is deprecated

#151 code423n4 closed 2 years ago
1
Factory can block auctions

#150 code423n4 opened 2 years ago
1
Publisher can scam users by changing license fees and using auction to freeze user funds

#149 code423n4 closed 2 years ago
2
In `validateWeights` cache `_tokens[i]`

#148 code423n4 closed 2 years ago
1
Division with `BASE` twice can be optimized

#147 code423n4 opened 2 years ago
0
`maxSupply` can be exceeded

#146 code423n4 opened 2 years ago
2
Change in `auctionMultiplier/auctionDecrement` change profitability of auctions and factory can steal all tokens from a basket abusing it

#145 code423n4 opened 2 years ago
3
`Basket.sol#auctionBurn` calculates `ibRatio` wrong

#144 code423n4 opened 2 years ago
1
`handleFees` can be implemented more efficiently

#143 code423n4 closed 2 years ago
1
`mintTo` has not an extra require statement

#142 code423n4 opened 2 years ago
1
Inconsistent usage of `safeApprove`

#141 code423n4 closed 2 years ago
2
Loops can be implemented more efficiently

#140 code423n4 opened 2 years ago
0
For uint `> 0` can be replaced with ` != 0` for gas optimization

#139 code423n4 opened 2 years ago
0
Use negate(!) rather than `== false`

#138 code423n4 opened 2 years ago
0
Extra payments for an auction gets stucks

#137 code423n4 opened 2 years ago
2
`settleAuction()` method could be set external instead public

#136 code423n4 closed 2 years ago
1
TODO comments should be resolved

#135 code423n4 opened 2 years ago
2
`BasketLicenseProposed` better emit proposal id

#134 code423n4 opened 2 years ago
2
Gas Optimization: Struct layout

#133 code423n4 closed 2 years ago
1
Gas Optimization: Mark immutable variables

#132 code423n4 closed 2 years ago
1
Gas Optimization: Mark immutable variables

#131 code423n4 closed 2 years ago
1
Gas Optimization: Use calldata instead of memory

#130 code423n4 opened 2 years ago
0
Gas Optimization: Reorder storage layout

#129 code423n4 opened 2 years ago
0
Mint method could be set external instead public

#128 code423n4 closed 2 years ago
1