code-423n4 2022-01-trader-joe-findings issues

code-423n4 / 2022-01-trader-joe-findings

2 stars 0 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

Code does not follow the best practice of check-effects-interaction

#321 marchev opened 1 year ago
0
ERC20 transfer might fail

#320 code423n4 closed 2 years ago
1
Cheaper operation should be done first in an if statement

#319 code423n4 opened 2 years ago
1
!= 0 is cheaper than >0 for uint

#318 code423n4 closed 2 years ago
1
Anyone can call deposit or withdraw with zero amount (LaunchEvent.sol)

#317 code423n4 closed 2 years ago
2
Timelock could be set to 0

#316 code423n4 closed 2 years ago
2
transferFrom return value unchecked

#315 code423n4 closed 2 years ago
2
Lack of input checks (withrawal penalties should always be greater than 0)

#314 code423n4 opened 2 years ago
2
Event for withdraws is never emitted

#313 code423n4 closed 2 years ago
2
user can withdraw avax without paying penalty fees

#312 code423n4 closed 2 years ago
3
Variables could be inmutable

#311 code423n4 closed 2 years ago
1
Gas Optimziation: Unnecessary pairBalance call

#310 code423n4 opened 2 years ago
1
Gas Optimization: Use type(uint256).max instead of block.timestamp

#309 code423n4 opened 2 years ago
0
Save Gas With The Unchecked Keyword (LaunchEvent.sol)

#308 code423n4 closed 2 years ago
1
Event Is Defined But Not Used On The Contract (IssuingTokenDeposited)

#307 code423n4 closed 2 years ago
2
factory can be set to address(0)

#306 code423n4 closed 2 years ago
1
router can be set to address(0)

#305 code423n4 closed 2 years ago
1
penaltyCollector can be set to address(0)

#304 code423n4 closed 2 years ago
1
Reasonable upper limits for phase durations

#303 code423n4 opened 2 years ago
0
_atPhase optimization

#302 code423n4 closed 2 years ago
1
PRECISION is constant

#301 code423n4 closed 2 years ago
2
Repeated storage access

#300 code423n4 opened 2 years ago
0
Long revert messages

#299 code423n4 closed 2 years ago
1
need to check if pending value = 0

#298 code423n4 closed 2 years ago
1
Cache storage variables

#297 code423n4 closed 2 years ago
1
Unchecked math operations

#296 code423n4 opened 2 years ago
0
Unchecked math operations

#295 code423n4 opened 2 years ago
0
Separate issuer functions from regular users

#294 code423n4 opened 2 years ago
0
Gas Optimization: Variables that could be set constant

#293 code423n4 closed 2 years ago
2
Cache phase3Start

#292 code423n4 closed 2 years ago
1
Unsafe call to decimals()

#291 code423n4 opened 2 years ago
0
Gas Optimization: fmul optimization

#290 code423n4 opened 2 years ago
0
Use safe transfers and approvals

#289 code423n4 closed 2 years ago
1
Frontrun setRJoe

#288 code423n4 closed 2 years ago
2
transferFrom can return false, and didnt revert

#287 code423n4 closed 2 years ago
2
Remove unused variable

#286 code423n4 closed 2 years ago
2
Re-entrancy protection

#285 code423n4 closed 2 years ago
1
Gas Optimization: Variables that could be set immutable

#284 code423n4 opened 2 years ago
0
Gas Optimization: `> 0` is less efficient than `!= 0` for uint in require condition

#283 code423n4 closed 2 years ago
1
Use constructors

#282 code423n4 opened 2 years ago
0
less gas used `_owner` instead of call function `owner()`

#281 code423n4 closed 2 years ago
2
Possible trolling during deployemnt

#280 code423n4 closed 2 years ago
2
Cache internal call result

#279 code423n4 closed 2 years ago
1
Error never thrown

#278 code423n4 opened 2 years ago
0
Minimize operations

#277 code423n4 closed 2 years ago
1
Owner can DoS `withdrawAVAX()` function

#276 code423n4 closed 2 years ago
3
Mark constant variables constant

#275 code423n4 closed 2 years ago
2
Mark unchanging variables immutable

#274 code423n4 opened 2 years ago
2
Unspecific Compiler Version Pragma

#273 code423n4 closed 2 years ago
2
Unsafe ERC20 Operation(s)

#272 code423n4 closed 2 years ago
2